Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--longDescription is not mandatory #411

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented May 27, 2024

Fixes #408

@kelson42 kelson42 requested a review from rgaudin May 27, 2024 11:19
@rgaudin
Copy link
Member

rgaudin commented May 27, 2024

I doubt this will fix #408 ; it's not just a usage issue

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 26.98%. Comparing base (663b9ca) to head (88cf916).

Files Patch % Lines
src/zimwriterfs/zimwriterfs.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   26.97%   26.98%           
=======================================
  Files          26       26           
  Lines        2450     2453    +3     
  Branches     1336     1338    +2     
=======================================
+ Hits          661      662    +1     
- Misses       1302     1304    +2     
  Partials      487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor Author

@rgaudin It is indeed not just a usage() change

src/zimwriterfs/zimwriterfs.cpp Outdated Show resolved Hide resolved
@kelson42 kelson42 force-pushed the longdescription-non-mandatory branch from 134920d to 88cf916 Compare June 2, 2024 15:17
@kelson42 kelson42 merged commit d6c6a1b into main Jun 2, 2024
10 of 12 checks passed
@kelson42 kelson42 deleted the longdescription-non-mandatory branch June 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LongDescription incorrectly marked as mandatory
3 participants